feat: input validation for resource creation #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize resource creation logic & add basic input validation.
Issues this PR fixes:
createdAt
orfingerprint
E2e tests are closer to passing, now the only failures should be:
TestCreateInvalidGroup/non-existent_receiver
- creating group with invalid receiver yields 5xx response instead of 4xx. This happens because there's no code checks, only a failed foreign key constraint from the db layerTestToggleGroup
- UpdatedAt field never updated. Gorm should do this automatically but is "broken" by us using types besidestime.Time
(we use a custom graph scalar)Closes #70